Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook Container Not Disabling Facebook Buttons on TheAtlantic.com #525

Open
HURSSGH opened this issue Oct 16, 2019 · 3 comments
Open

Facebook Container Not Disabling Facebook Buttons on TheAtlantic.com #525

HURSSGH opened this issue Oct 16, 2019 · 3 comments
Labels
🐛 bug Something isn't working needs-priority This issue needs prioritization web-compatibility Issue related to website compatibility
Projects
Triage

Comments

@HURSSGH
Copy link

HURSSGH commented Oct 16, 2019

Facebook Container does not disable buttons on all websites. For example:
https://www.theatlantic.com/photo/2019/10/winners-of-the-wildlife-photographer-of-the-year-2019/600130/

The Facebook button right below the "Hints" paragraph and above the photo, is not disabled. When you click on it, it tries to log you into Facebook, passing the link when refers to that page in The Atlantic.

I AM GLAD YOU ASKED THIS. NOW I AM GOING TO GO DISABLE SOME OF THE HIDDEN EXTENSIONS !!!!

Actual behavior

Expected behavior

Steps to reproduce

Notes
@maxxcrawford maxxcrawford changed the title Facebook Container Not Disabling Facebook Buttons on Some Sites Facebook Container Not Disabling Facebook Buttons on TheAtlantic.com Oct 17, 2019
@maxxcrawford
Copy link
Member

Code snippet of the link in question:

<a href="#" class="social-icon facebook" data-share="facebook" data-omni-click="r'articlefb',r'',l.pathname">
  <span>Facebook</span>
</a>

@HURSSGH
Copy link
Author

HURSSGH commented Oct 19, 2019

Hi,

My original title (which I apparently don't have the ability to edit) may be the better title. The Atlantic is just the first place I submitted an example. Here's another one, this one from the BBC. If you prefer I open a new issue for each site with problems, please let me know.

For this BBC story:
https://www.bbc.com/news/disability-49584591

and apparently all BBC stories, the Facebook button gets disabled, but the messenger button next to it does not. This is from the "Share this story" section at the bottom of the article. Here is the link attached to the FB Messenger button:
http://www.facebook.com/dialog/send?app_id=58567469885&redirect_uri=https%3A%2F%2Fwww.bbc.com%2Fnews%2Fdisability-49584591&link=https%3A%2F%2Fwww.bbc.com%2Fnews%2Fdisability-49584591%3FSThisFB&display=popup

I've seen other places where the FB Container is failing and will add them as I have time to document them.

Thanks for the great work! I hope this helps debug it.

JK

@smnthermes
Copy link

Just use uBlock Origin or uMatrix. Unfortunately, Mozilla will probably follow Manifest v3 in order to conform to web standards, which are controlled by Google and include extensions.

@maxxcrawford maxxcrawford added needs-priority This issue needs prioritization web-compatibility Issue related to website compatibility 🐛 bug Something isn't working labels Jun 24, 2020
@maxxcrawford maxxcrawford added this to Needs Priority in Triage Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working needs-priority This issue needs prioritization web-compatibility Issue related to website compatibility
Projects
Triage
  
Needs Priority
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maxxcrawford @HURSSGH @smnthermes